Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Unity badges #193

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Add support for Unity badges #193

merged 5 commits into from
Jan 4, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Nov 19, 2023

Fixes #74
Fixes #201

Tested with Granite Demo. The DBus class is taken almost directly from Plank with code style fixes.

Screenshot from 2023-11-19 11 49 02

@danirabbit danirabbit requested a review from a team November 19, 2023 19:50
@jeremypw
Copy link

jeremypw commented Dec 4, 2023

This worked with granite-demo (and App Center notifications) but not with granite-7-demo. However, the existing Plank dock did work with granite-7-demo.

@leolost2605
Copy link
Member

leolost2605 commented Jan 2, 2024

I'm not sure but I think this might be a problem with granite demo. The application id set there is io.elementary.granite.demo which is used by granite to send the unity entry but the desktop file is io.elementary.granite-7.demo which is what gala and therefore dock know about. Plank only works because it adds a second app for the unity entry which has no icon etc. I'm not sure though what the preferred behavior here is. IMO it's better to hide it entirely (like it's done in this PR)

@danirabbit
Copy link
Member Author

Yeah I think the correct behavior is to make sure we're getting a consistent ID so that apps can't pretend to be other apps etc

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only one minor nitpick :)

src/LauncherManager.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit force-pushed the danirabbit/unity-badges branch from 0eb19dd to 559cef4 Compare January 4, 2024 20:14
@danirabbit danirabbit requested a review from leolost2605 January 4, 2024 20:17
@leolost2605 leolost2605 merged commit dcdac4f into main Jan 4, 2024
4 checks passed
@leolost2605 leolost2605 deleted the danirabbit/unity-badges branch January 4, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Show badges from launcher API Use the new badge style for notification badges
3 participants