Fix smart category not saving

apps/web/app/(app)/automation/RuleForm.tsx

@@ -55,7 +55,7 @@ import type { LabelsResponse } from "@/app/api/google/labels/route";
 import { MultiSelectFilter } from "@/components/MultiSelectFilter";
 import { useCategories } from "@/hooks/useCategories";
 import { hasVariables } from "@/utils/template";
-import { getEmptyConditions } from "@/utils/condition";
+import { getEmptyCondition } from "@/utils/condition";
 import { AlertError } from "@/components/Alert";
 import { RadioGroup, RadioGroupItem } from "@/components/ui/radio-group";
 
@@ -155,12 +155,8 @@ export function RuleForm({ rule }: { rule: CreateRuleBody & { id?: string } }) {
 
   const conditions = watch("conditions");
   const unusedCondition = useMemo(() => {
-    const usedConditions = conditions?.map(({ type }) => type);
-    const emptyConditions = getEmptyConditions();
-    const unusedCondition = emptyConditions.find(
-      (condition) => !usedConditions?.includes(condition.type),
-    );
-    return unusedCondition;
+    const usedConditions = new Set(conditions?.map(({ type }) => type));
+    return Object.values(RuleType).find((type) => !usedConditions.has(type));
   }, [conditions]);
 
   // biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
@@ -224,9 +220,7 @@ export function RuleForm({ rule }: { rule: CreateRuleBody & { id?: string } }) {
                         });
                       }
 
-                      const emptyCondition = getEmptyConditions().find(
-                        (condition) => condition.type === selectedType,
-                      );
+                      const emptyCondition = getEmptyCondition(selectedType);
                       if (emptyCondition) {
                         setValue(`conditions.${index}`, emptyCondition);
                       }
@@ -439,7 +433,7 @@ export function RuleForm({ rule }: { rule: CreateRuleBody & { id?: string } }) {
             type="button"
             variant="secondary"
             className="w-full"
-            onClick={() => appendCondition(unusedCondition)}
+            onClick={() => appendCondition(getEmptyCondition(unusedCondition))}
           >
             <PlusIcon className="mr-2 h-4 w-4" />
             Add Condition
@@ -477,10 +471,6 @@ export function RuleForm({ rule }: { rule: CreateRuleBody & { id?: string } }) {
                 </div>
                 <div className="space-y-4 sm:col-span-3">
                   {actionInputs[action.type].fields.map((field) => {
-                    console.log(
-                      "🚀 ~ {actionInputs[action.type].fields.map ~ field:",
-                      field,
-                    );
                     const isAiGenerated = action[field.name]?.ai;
 
                     const value = watch(`actions.${i}.${field.name}.value`);

apps/web/app/(app)/automation/TestRules.tsx

@@ -111,7 +111,6 @@ export function TestRulesContent() {
         description: result.error,
       });
     } else {
-      console.log("🚀 ~ onTest ~ result:", result);
       setTestResults((prev) => ({ ...prev, [message.id]: result }));
     }
     setIsTesting((prev) => ({ ...prev, [message.id]: false }));

apps/web/utils/condition.ts

@@ -94,62 +94,40 @@ export function getConditionTypes(
   );
 }
 
-const aiEmptyCondition = {
-  type: RuleType.AI,
-  instructions: "",
-};
-
-const groupEmptyCondition = {
-  type: RuleType.GROUP,
-  groupId: "",
-};
-
-const staticEmptyCondition = {
-  type: RuleType.STATIC,
-  from: null,
-  to: null,
-  subject: null,
-  body: null,
-};
-
-const categoryEmptyCondition = {
-  type: RuleType.CATEGORY,
-  categoryFilterType: null,
-  categoryFilters: null,
-};
-
-export function getEmptyConditions(): ZodCondition[] {
-  return [
-    aiEmptyCondition,
-    groupEmptyCondition,
-    staticEmptyCondition,
-    categoryEmptyCondition,
-  ];
-}
-
 export function getEmptyCondition(
   type: RuleType,
   groupId?: string,
   category?: string,
 ): ZodCondition {
   switch (type) {
     case RuleType.AI:
-      return aiEmptyCondition;
+      return {
+        type: RuleType.AI,
+        instructions: "",
+      };
     case RuleType.GROUP:
       return {
-        ...groupEmptyCondition,
+        type: RuleType.GROUP,
         groupId: groupId || "",
       };
     case RuleType.STATIC:
-      return staticEmptyCondition;
+      return {
+        type: RuleType.STATIC,
+        from: null,
+        to: null,
+        subject: null,
+        body: null,
+      };
     case RuleType.CATEGORY:
       return {
-        ...categoryEmptyCondition,
-        categoryFilters: category ? [category] : null,
+        type: RuleType.CATEGORY,
         categoryFilterType: CategoryFilterType.INCLUDE,
+        categoryFilters: category ? [category] : null,
       };
     default:
-      throw new Error(`Invalid condition type: ${type}`);
+      // biome-ignore lint/correctness/noSwitchDeclarations: intentional exhaustive check
+      const exhaustiveCheck: never = type;
+      return exhaustiveCheck;
   }
 }