Update README.md #15
Open
Update README.md #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliegoudout
requested changes
Jan 8, 2025
| @@ -54,7 +54,7 @@ To solve this problem, we propose a base `ParamClass` and an `@protected` decora | |||
|
|
|||
| First of all, the `@dataclass(frozen=True)` decorator only applies protection to instances. Besides, it targets all attributes indifferently. Morover, it does not protect against deletion or direct `vars(instance)` manipulation. Finally, protection is not inherited, thus subclasses need to use the decorator again, while being cautious not to silently override previously protected attributes. | |||
|
|
|||
| The `typing` alternatives [`@final`](https://docs.python.org/3/library/typing.html#typing.final) and [`Final`](https://docs.python.org/3/library/typing.html#typing.Final) are designed for type checkers on which we do not want to rely. From python 3.11 onwards, `final` _does_ add a `__final__` flag when possible, but it will not affect immutable objects. | |||
| The `typing` alternatives [`@final`](https://docs.python.org/3/library/typing.html#typing.final) and [`Final`](https://docs.python.org/3/library/typing.html#typing.Final) are designed for type checkers only which we do not want to rely on. From python 3.11 onwards, `final` _does_ add a `__final__` flag when possible, but it will not affect immutable objects. | |||
There was a problem hiding this comment.
Yes, with missing coma "checkers only, which..."
| @@ -457,4 +457,4 @@ uv run python # Interactive session in virtual environme | |||
|
|
|||
| This package is distributed under the [MIT License](LICENSE). | |||
|
|
|||
| <sup>Back to [Table of Contents](#readme)👆</sup> | |||
There was a problem hiding this comment.
I just push-added missing trailing \n alongside short commit, idk if it was the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.