feat: update figure label and max heading level #1613
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview environment images deployed!The preview environment has been updated: Client URL: https://pr-1613--epp.elifesciences.org Note: Updated images can take a few minutes to roll out. |
Preview environment created!The preview environment has been deployed to the cluster. Client URL: https://pr-1613--epp.elifesciences.org Note: If this is a new environment, it can take a few minutes for DNS to update. |
Update the figure label element from "label" to "h4" in figure.tsx. Also, adjust the max heading level from 4 to 5 in content-to-jsx.tsx.
nlisgo
force-pushed
the
figure-label-a11y
branch
from
06d2cd2 to
6dced7e
Compare
|
I would have expected this to fail the visual regression test. We should investigate this on Monday! |
|
@nlisgo Your expectation that this should fail visual regression is now true with chromatic. Fancy resurrecting it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the figure label element from "label" to "h4" in figure.tsx. Also, adjust the max heading level from 4 to 5 in content-to-jsx.tsx.
After a brief discussion with @discodavey we thought this approach was worth consideration.