-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor content twig file for grid framework #1594
base: develop
Are you sure you want to change the base?
Conversation
I can help with the failing tests if you need it. Not sure why the white space is being introduced based on the changes coming in but if you are happy with the whitespaces being there then we should improve the tests so that it passes with or without the whitespaces. |
I think it's weird that the tests are failing. Did they ever work before? Do we need the whitespaces? If not then we can remove them. |
The tests worked before because there was no whitespace before. If you wish to remove the whitespace then we will need to do more work in pattern library to eliminate the whitespace. Or we need to make the test work with or without the whitespace. However, since this is just a demo to determine if fit for release then we could just quickly suppress the tests to be able to deploy the demo instance. |
…hub.com:elifesciences/journal into add-css-grid-framework
This reverts commit 2e060f5.
No description provided.