Prefer Make targets over bash scripts

elifesciences · Jan 15, 2025 · 593bd9b · 593bd9b
1 parent 311086e
commit 593bd9b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -25,7 +25,7 @@ test: bring-up-app-and-queue-watcher
 	docker compose exec app vendor/bin/phpunit $(TEST)
 
 .PHONY: all-checks
-all-checks: bring-up-app-without-queue-watcher
+all-checks: bring-up-app-without-queue-watcher static-analysis test
 	docker compose exec app bash project_tests.sh
 
 .PHONY: stop

diff --git a/project_tests.sh b/project_tests.sh
@@ -13,11 +13,6 @@ function cleanup {
 }
 trap cleanup EXIT
 
-vendor/bin/phpcs --standard=phpcs.xml.dist --warning-severity=0 -p src/ tests/ web/
-vendor/bin/composer-dependency-analyser
-vendor/bin/phpstan analyse
-vendor/bin/phpunit
-
 echo "Creating, deleting an index"
 bin/ci-lifecycle