fix: Select 5 post examples in runtime instead of 50. #2630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just removed one character.
in
formattedCharacterPostExamples
, I believe it should sample 5 examples, not 50. In the case of 50, then if a character has 50 or less post examples then she will have 0 entropy on the post examples from post to post.5 makes more sense, because: Message examples samples 5, Lore samples 10, bio samples 3, knowledge samples 5. I don't think we need to sample 50 post examples, I think 5 makes more sense for the following reasons:
Happy Coding 🙏