Do not depend on nor require haskell-mode
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschrempf
force-pushed
the
rm-dep-haskell-mode
branch
from
34db0b8 to
f5214c6
Compare
michaelpj
reviewed
Jan 22, 2025
|
|
||
| You will need to set some hooks to ensure that `lsp-mode` is triggered when the `haskell-mode` major mode is entered. | ||
| You will need to set some hooks to ensure that `lsp-mode` is triggered when your Haskell major mode (e.g., `haskell-mode` or `haskell-ts-mode`) is entered. |
There was a problem hiding this comment.
Is this actually required? I'm not sure I have this? Is this handled now by the :major-modes thing in lsp-mode now?
I definitely don't want it to be the case that everyone has to add hooks, but I think maybe they already don't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #188.
I tried using
lsp-haskellwithhaskell-mode, andhaskell-ts-mode, and both seems to work. However, I suggest other people testing their setups.