Move inversion step to right context

Not all MC acquisitions functions use best_f (e.g. qUCB), causing a KeyError in these cases
emdgroup · Jan 22, 2025 · 4fdd687 · 4fdd687
1 parent 1fd11f5
commit 4fdd687
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/baybe/acquisition/base.py b/baybe/acquisition/base.py
@@ -111,11 +111,12 @@ def to_botorch(
                     additional_params["best_f"] = (
                         bo_surrogate.posterior(train_x).mean.min().item()
                     )
+                    if self.is_mc:
+                        additional_params["best_f"] *= -1.0
 
                 if issubclass(acqf_cls, bo_acqf.AnalyticAcquisitionFunction):
                     additional_params["maximize"] = False
-                elif issubclass(acqf_cls, bo_acqf.MCAcquisitionFunction):
-                    additional_params["best_f"] *= -1.0
+                elif self.is_mc:
                     additional_params["objective"] = LinearMCObjective(
                         torch.tensor([-1.0])
                     )