Sync upstream

.github/workflows/elixir.yml

@@ -10,15 +10,15 @@ on:
 
 jobs:
   format:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: erlef/setup-beam@v1
         with:
-          otp-version: '25.0'
-          elixir-version: '1.13.4'
+          otp-version: '26.1.2'
+          elixir-version: '1.15.7'
           version-type: 'strict'
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         name: Cache
         with:
           path: |
@@ -34,22 +34,24 @@ jobs:
     name: Test SDK on Elixir ${{ matrix.elixir_version }} (OTP ${{ matrix.otp_version }}) and ${{ matrix.os }}
     strategy:
       matrix:
-        otp_version: ['25.0.3', '24.1.2']
-        elixir_version: ['1.14', '1.13.4']
-        rebar3_version: ['3.20.0']
+        otp_version: ['26.1.2', '24.3.4.14']
+        elixir_version: ['1.15.7', '1.12.3']
+        rebar3_version: ['3.22.1']
         os: [ubuntu-20.04]
+        exclude:
+          - elixir_version: "1.12.3"
+          - otp_version: "26.1.2"
     env:
       OTP_VERSION: ${{ matrix.otp_version }}
       ELIXIR_VERSION: ${{ matrix.elixir_version }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: erlef/setup-beam@v1
         with:
           otp-version: ${{ matrix.otp_version }}
           elixir-version: ${{ matrix.elixir_version }}
           rebar3-version: ${{ matrix.rebar3_version }}
           version-type: 'strict'
-      - run: mix local.rebar --force rebar3 /home/runner/work/_temp/.setup-beam/rebar3/bin/rebar3
       - name: Compile
         run: rebar3 as test compile
       - name: ExUnit
@@ -60,25 +62,28 @@ jobs:
     name: Test API on Elixir ${{ matrix.elixir_version }} (OTP ${{ matrix.otp_version }}) and ${{ matrix.os }}
     strategy:
       matrix:
-        otp_version: ['25.0.3', '24.1.2']
-        elixir_version: ['1.14', '1.13.4']
-        rebar3_version: ['3.20.0']
+        otp_version: ['26.1.2', '24.3.4.14']
+        elixir_version: ['1.15.7', '1.12.3']
+        rebar3_version: ['3.22.1']
         os: [ubuntu-20.04]
+        exclude:
+          - elixir_version: "1.12.3"
+          - otp_version: "26.1.2"
     env:
       OTP_VERSION: ${{ matrix.otp_version }}
       ELIXIR_VERSION: ${{ matrix.elixir_version }}
     defaults:
       run:
         working-directory: apps/opentelemetry_api/
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: erlef/setup-beam@v1
         with:
           otp-version: ${{ matrix.otp_version }}
           elixir-version: ${{ matrix.elixir_version }}
           rebar3-version: ${{ matrix.rebar3_version }}
           version-type: 'strict'
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         name: Cache
         with:
           path: |
@@ -87,12 +92,11 @@ jobs:
           key: ${{ runner.os }}-build-${{ matrix.otp_version }}-${{ matrix.elixir_version }}-v4-${{ hashFiles(format('{0}{1}', github.workspace, '/apps/opentelemetry_api/mix.lock')) }}
           restore-keys: |
             ${{ runner.os }}-build-${{ matrix.otp_version }}-${{ matrix.elixir_version }}-
-      - run: mix local.rebar --force rebar3 /home/runner/work/_temp/.setup-beam/rebar3/bin/rebar3
       - run: mix deps.get
         name: Deps
       - run: mix test --cover
         name: ExUnit
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v4
         if: ${{ always() }}
         with:
           file: apps/opentelemetry_api/coverage.xml
@@ -104,8 +108,9 @@ jobs:
     name: Dialyze on Elixir ${{ matrix.elixir_version }} (OTP ${{ matrix.otp_version }}) and ${{ matrix.os }}
     strategy:
       matrix:
-        otp_version: ['25.0']
-        elixir_version: ['1.14']
+        otp_version: ['26.1.2']
+        elixir_version: ['1.15.7']
+        rebar_version: ['3.22.1']
         os: [ubuntu-20.04]
     env:
       OTP_VERSION: ${{ matrix.otp_version }}
@@ -114,13 +119,13 @@ jobs:
       run:
         working-directory: apps/opentelemetry_api/
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: erlef/setup-beam@v1
         with:
           otp-version: ${{ matrix.otp_version }}
           elixir-version: ${{ matrix.elixir_version }}
           version-type: 'strict'
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         name: Cache
         with:
           path: |

.github/workflows/erlang.yml

@@ -18,25 +18,25 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        otp_version: ['26.0', '25.0.3', '24.1.2']
+        otp_version: ['26.1.2', '25.3.2.7', '24.3.4.14']
         rebar3_version: ['3.22.1']
         os: [ubuntu-20.04]
         include:
-          - otp_version: '23.3'
+          - otp_version: '23.3.4.19'
             rebar3_version: '3.17.0'
             os: ubuntu-20.04
     env:
       OTP_VERSION: ${{ matrix.otp_version }}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Run Collector
       run: docker-compose up -d
     - uses: erlef/setup-beam@v1
       with:
         otp-version: ${{ matrix.otp_version }}
         rebar3-version: ${{ matrix.rebar3_version }}
         version-type: 'strict'
-    - uses: actions/cache@v2
+    - uses: actions/cache@v4
       name: Cache
       with:
         path: |
@@ -52,7 +52,7 @@ jobs:
       run: rebar3 ct --cover
 
     - name: Publish Test Report
-      uses: mikepenz/action-junit-report@v3
+      uses: mikepenz/action-junit-report@v4
       if: success() || failure() # always run even if the previous step fails
       with:
         report_paths: '**/_build/test/logs/*/junit_report.xml'
@@ -62,25 +62,25 @@ jobs:
     - name: Covertool
       if: ${{ always() }}
       run: rebar3 covertool generate
-    - uses: codecov/codecov-action@v3
+    - uses: codecov/codecov-action@v4
       if: ${{ always() }}
       with:
         file: _build/test/covertool/opentelemetry.covertool.xml
         env_vars: OTP_VERSION
         flags: sdk,erlang
-    - uses: codecov/codecov-action@v3
+    - uses: codecov/codecov-action@v4
       if: ${{ always() }}
       with:
         file: _build/test/covertool/opentelemetry_api.covertool.xml
         env_vars: OTP_VERSION
         flags: api,erlang
-    - uses: codecov/codecov-action@v3
+    - uses: codecov/codecov-action@v4
       if: ${{ always() }}
       with:
         file: _build/test/covertool/opentelemetry_exporter.covertool.xml
         env_vars: OTP_VERSION
         flags: exporter,erlang
-    - uses: codecov/codecov-action@v3
+    - uses: codecov/codecov-action@v4
       if: ${{ always() }}
       with:
         file: _build/test/covertool/opentelemetry_zipkin.covertool.xml
@@ -91,17 +91,17 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        otp_version: ['26.0']
+        otp_version: ['26.1.2']
         rebar3_version: ['3.22.1']
         os: [ubuntu-20.04]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: erlef/setup-beam@v1
       with:
         otp-version: ${{ matrix.otp_version }}
         rebar3-version: ${{ matrix.rebar3_version }}
         version-type: 'strict'
-    - uses: actions/cache@v2
+    - uses: actions/cache@v4
       name: Cache
       with:
         path: |
@@ -119,17 +119,17 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        otp_version: ['26.0']
+        otp_version: ['26.1.2']
         rebar3_version: ['3.22.1']
         os: [ubuntu-20.04]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: erlef/setup-beam@v1
       with:
         otp-version: ${{ matrix.otp_version }}
         rebar3-version: ${{ matrix.rebar3_version }}
         version-type: 'strict'
-    - uses: actions/cache@v2
+    - uses: actions/cache@v4
       name: Cache
       with:
         path: |

.github/workflows/labeler.yml

@@ -5,6 +5,6 @@ jobs:
   triage:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/labeler@main
+    - uses: actions/labeler@v4
       with:
         repo-token: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/w3c_interop.yml

@@ -11,15 +11,15 @@ on:
 jobs:
   interop_tests:
     name: Run W3C Trace Context Interop Tests
-    runs-on: ubuntu-20.04
-    env:
-      OTP_VERSION:
+    runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: erlef/setup-beam@v1
       with:
-        otp-version: '26.0'
-    - uses: actions/cache@v2
+        otp-version: '26.1.2'
+        version-type: strict
+        rebar3-version: '3.22.1'
+    - uses: actions/cache@v4
       name: Cache
       with:
         path: |
@@ -31,14 +31,14 @@ jobs:
     - name: Compile
       run: rebar3 as interop compile
 
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         repository: 'w3c/trace-context'
         path: 'trace-context'
     - name: Setup python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
-        python-version: 3.6
+        python-version: 3.12
         architecture: x64
     - run: pip install aiohttp
     - run: |

CHANGELOG.md

@@ -25,18 +25,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [Attributes module `otel_attributes` moved to
   API](https://github.com/open-telemetry/opentelemetry-erlang/pull/618)
 
+### Fixes
+
+- [Fix leak of atoms/persistent terms by creating unique processor name in `otel_tracer_server`](https://github.com/open-telemetry/opentelemetry-erlang/pull/646)
+
 ## Experimental API
 
 ### Changes
 
-- [Allow to create observable instruments without passing callback arguments](https://github.com/open-telemetry/opentelemetry-erlang/pull/604)
+- [Allow to create observable instruments without passing callback
+  arguments](https://github.com/open-telemetry/opentelemetry-erlang/pull/604)
+- [Allow to give `advisory_params` to instrument creation functions](https://github.com/open-telemetry/opentelemetry-erlang/pull/628)
+- [Attributes are optional in Counter.add(), UpDownCounter.add() and Histo.record()](https://github.com/open-telemetry/opentelemetry-erlang/pull/632)
 
 ## Experimental SDK
 
 ### Added
 
 - [Add `instrument_unit` to view criteria](https://github.com/open-telemetry/opentelemetry-erlang/pull/604)
 - [Validate instrument name](https://github.com/open-telemetry/opentelemetry-erlang/pull/604)
+- [Handle `explict_bucket_boundaries` advisory parameter](https://github.com/open-telemetry/opentelemetry-erlang/pull/628)
+- [Rename `boundaries` to `explict_bucket_boundaries` in histogram explicit aggregation options](https://github.com/open-telemetry/opentelemetry-erlang/pull/628)
+- [Allow creating wildcard views](https://github.com/open-telemetry/opentelemetry-erlang/pull/624)
 
 ### Changes
 
@@ -46,6 +56,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
  - [Correctly record histogram values greater than last boundary](https://github.com/open-telemetry/opentelemetry-erlang/pull/614)
  - [Readers should use a default cumulative temporality if not specified](https://github.com/open-telemetry/opentelemetry-erlang/pull/613)
+ - [Check for positive data values in counters and histograms](https://github.com/open-telemetry/opentelemetry-erlang/pull/632)
 
 ## SDK 1.3.1 - 2023-08-15
 

apps/opentelemetry/src/otel_batch_processor.erl

@@ -12,14 +12,19 @@
 %% See the License for the specific language governing permissions and
 %% limitations under the License.
 %%
-%% @doc The Batch Span Processor implements the `otel_span_processor'
-%% behaviour. It stores finished Spans in a ETS table buffer and exports
+%% @doc The Batch Span Processor implements the {@link otel_span_processor}
+%% behaviour.
+%%
+%% It stores finished Spans in a ETS table buffer and exports
 %% them on an interval or when the table reaches a maximum size.
 %%
-%% Timeouts:
-%%   exporting_timeout_ms: How long to let the exports run before killing.
-%%   check_table_size_ms: Timeout to check the size of the export table.
-%%   scheduled_delay_ms: How often to trigger running the exporters.
+%% You can configure these timeouts:
+%%
+%% <ul>
+%% <li>`exporting_timeout_ms': how long to let the exports run before killing.</li>
+%% <li>`check_table_size_ms': timeout to check the size of the export table.</li>
+%% <li>`scheduled_delay_ms': how often to trigger running the exporters.</li>
+%% </ul>
 %%
 %% The size limit of the current table where finished spans are stored can
 %% be configured with the `max_queue_size' option.
@@ -76,6 +81,7 @@ start_link(#{name := Name} = Config) ->
             Err
     end.
 
+%% @private
 -spec on_start(otel_ctx:t(), opentelemetry:span(), otel_span_processor:processor_config())
               -> opentelemetry:span().
 on_start(_Ctx, Span, _) ->

apps/opentelemetry/src/otel_sampler_trace_id_ratio_based.erl

@@ -39,7 +39,7 @@
 setup(Probability) ->
     IdUpperBound =
         case Probability of
-            P when P =:= 0.0 ->
+            P when P == 0.0 ->
                 0;
             P when P =:= 1.0 ->
                 ?MAX_VALUE;