Fix check_type_size for Cmake when building with pthreads enabled #15590
Conversation
|
cc @sbc100 |
|
Quick reminder for this one @sbc100 :) |
Head branch was pushed to by a user without write access
|
This will have to be manually squash merged given that mac-os build doesn't run for me without upgrading my subscription :( I've filed a support ticket with CircleCI as well |
|
@shanumantesc Thanks for filing an issue with Circle - can you send me the link or cc me there, or something? I'd like to mention to them how serious of a problem this is for us in general. |
|
@kripken not sure if you can access this - https://support.circleci.com/hc/en-us/requests/100139 |
|
Thanks @shanumantesc - but yeah, your guess was right, I can't access it. I'll open a new issue with them then, just to make sure they have this problem connected to our account with them, which hopefully can help prioritize it. |
|
To get a CI run so we can merge this, I opened #15614 |
|
Looks like #15614 passed so landing this.. |
Previously we could only add this when we detect that we running under autoconf. With this change we now default to outputting a JS file that is executable unless as long as we are possibly targetting node (ENVIRONMENT_MAY_BE_NODE) and we are not optimizing for size (`-Oz` or `-Os`). Also, conditionally add `--experimental-wasm-threads` to the node command (similar to what we did in #15590) used in the #! line.
Addresses the cmake part of #15522