Ensure emscripten root is at the start of python path #22230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues where something called e.g. `tools` already exists in the python path. See emscripten-core/emsdk#1420 (comment)
|
I confirm that this resolves the issue for me, thanks! |
|
If you could approve then this change will auto-merge |
kleisauke
approved these changes
Jul 13, 2024
verhovsky
pushed a commit
to verhovsky/emscripten
that referenced
this pull request
Jul 30, 2024
…e#22230) This avoids issues where something called e.g. `tools` already exists in the python path. See emscripten-core/emsdk#1420 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids issues where something called e.g.
toolsalready exists in the python path.See emscripten-core/emsdk#1420 (comment)