[embind] Simplify string.toWireType. NFC #23369
Open
+18
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sbc100
commented
Jan 10, 2025
•
sbc100
commented
- Simplify the type check
- Restructure the loop to avoid checking stdStringIsUTF8 twice
sbc100
force-pushed
the
string_toWireType
branch
3 times, most recently
from
466eb50 to
96ed3ac
Compare
sbc100
changed the title
brendandahl
reviewed
Jan 10, 2025
sbc100
force-pushed
the
string_toWireType
branch
from
96ed3ac to
bf74d1c
Compare
sbc100
force-pushed
the
string_toWireType
branch
from
bf74d1c to
6d496c4
Compare
- Simplify the type check - Remove the final argument from sringToUTF8 - Restructure the loop to avoid checking stdStringIsUTF8 twice
sbc100
force-pushed
the
string_toWireType
branch
from
6d496c4 to
ad13882
Compare
brendandahl
reviewed
Jan 11, 2025
| if (valueIsOfTypeString) { | ||
| if (valueIsOfTypeString) { | ||
| if (stdStringIsUTF8) { | ||
| stringToUTF8(value, ptr, length); |
There was a problem hiding this comment.
Looks like tests are still failing, + 1 is needed or something else going on?
There was a problem hiding this comment.
Yup, you are correct.
Strange.. his code doesn't actually require null termination (it uses lenght-pefix instead)... but stringToUTF8 unconditionally does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.