Allow emscripten-releases-tags/aliases to work be used without SDK deps #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
aliases_for_releases
branch
from
a9e1f8e to
290654f
Compare
sbc100
force-pushed
the
aliases_for_releases
branch
2 times, most recently
from
8987532 to
f2b0c0e
Compare
This change means that aliases such as `latest` and `3.10.2` can be used to install jsut the emscipten-releases packages and not the full SDK with all the dependencies. This allows uses who do not want to install dependencies such as node, python or java to still use this package. These packages were already available to install on their own via their full names such as: ``` $ ./emsdk install releases-upstream-48ce0b44015d0182fc8c27aa9fbc0a4474b55982-64bi ``` Now these base packages can also be install via: ``` $ ./emsdk install latest-base ``` Fixes: #1142
sbc100
force-pushed
the
aliases_for_releases
branch
from
f2b0c0e to
bcd05f7
Compare
|
This code looks fine, although the suffix "-base" isn't very clear on what it means. Would a name that refers more directly to "emscripten" (or perhaps "toolchain") make more sense? On one hand something like "emscripten-only" would be weird for us (who see emscripten proper as one of the components alongside LLVM and Binaryen) but I'd bet that users wouldn't see it that way, so for them emscripten would be the toolchain and the language runtimes would be something else. |
|
oh, and is there some doc that should be updated? |
|
Closing now that the need for this is less since #1189 landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that aliases such as
latestand3.10.2can be used to install jsut the emscipten-releases packages and not the full SDK with all the dependencies.This allows uses who do not want to install dependencies such as node, python or java to still use this package.
These packages were already available to install on their own via their full names such as:
Now these base packages can also be install via:
Fixes: #1142