Allow system npm in "emsdk install emscripten" #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"emsdk install emscripten-master-64bit" is currently dependent on whether emscripten node is installed or not. This change allow using system-provided node / npm command to proceed the installation. Also clarify the error message.
sbc100
reviewed
Feb 22, 2021
emsdk.py
Outdated
| try: | ||
| subprocess.check_output(['npm' + ('.cmd' if WINDOWS else ''), '--version'], stderr=subprocess.STDOUT, universal_newlines=True) | ||
| node_path = os.path.dirname(shutil.which('npm' + ('.cmd' if WINDOWS else ''))) | ||
| except subprocess.CalledProcessError: |
There was a problem hiding this comment.
We have a local which function in this file which you can use rather than shtuil.which (since we want to support python2).
You don't need the try/catch then either. You an just do 'node_path = which ...and thenif not node_path`
sbc100
approved these changes
Feb 23, 2021
akoeplinger
pushed a commit
to akoeplinger/emsdk
that referenced
this pull request
Dec 13, 2024
…scripten-core#723) [main] Update dependencies from dotnet/binaryen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"emsdk install emscripten-master-64bit" is currently dependent on whether emscripten node is installed or not.
This change allow using system-provided node / npm command to proceed the installation. Also clarify the error message.
Other alternatives:
#640 maybe addresses this for a different reason
I don't think #714 addresses this
Another alternative is to provide node.js in source form (and compile it) if "emsdk install emscripten" must use emscripten node / npm, to which also can address #623