-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more commands to the encointer-client docker image and test them in CI #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the faucet service
clangenb
force-pushed
the
cl/enrich-client-with-more-python-files
branch
from
January 15, 2025 11:58
994cb70
to
622b845
Compare
clangenb
commented
Jan 15, 2025
clangenb
commented
Jan 15, 2025
clangenb
changed the title
Add more commands to the encointer-client docker image
Add more commands to the encointer-client docker image and test them in CI
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In essence this introduces the feature to run the bot-community, phase.py and faucet.py from the enconter-client docker container. To achieve that, a few minor changes were necessary:
phase.py
CLI has had minor adjustements to be able to run from within a docker containerfaucet.py
now takes some arguments and exposes0.0.0.0
instead of localhost to be reachable from outside the docker-u
as a url argument.-r
has been removed.Tests:
Future work: