Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more commands to the encointer-client docker image and test them in CI #385

Merged
merged 36 commits into from
Jan 15, 2025

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Jan 15, 2025

In essence this introduces the feature to run the bot-community, phase.py and faucet.py from the enconter-client docker container. To achieve that, a few minor changes were necessary:

  • The phase.py CLI has had minor adjustements to be able to run from within a docker container
  • The faucet.py now takes some arguments and exposes 0.0.0.0 instead of localhost to be reachable from outside the docker
  • Breaking: unify the CLI for our scripts in general such that there is only -u as a url argument. -r has been removed.

Tests:

  • The CI does now also run the bootstrap and the bot-community integration tests in docker to ensure that the docker works.

Future work:

@clangenb clangenb force-pushed the cl/enrich-client-with-more-python-files branch from 994cb70 to 622b845 Compare January 15, 2025 11:58
@clangenb clangenb requested a review from brenzi January 15, 2025 13:19
@clangenb clangenb changed the title Add more commands to the encointer-client docker image Add more commands to the encointer-client docker image and test them in CI Jan 15, 2025
@clangenb clangenb merged commit 45f120e into master Jan 15, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants