forked from endless-sky/endless-sky
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code(feat): Additional Scan Information and modular access #2
Merged
RisingLeaf
merged 112 commits into
endless-sky:experimental
from
Zitchas:code(feat)-VC-UI-Info_v1
Mar 28, 2023
Merged
Code(feat): Additional Scan Information and modular access #2
RisingLeaf
merged 112 commits into
endless-sky:experimental
from
Zitchas:code(feat)-VC-UI-Info_v1
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds icons & code for: - gun range - turret range - turn speed New icons by Zitchas Code originally by Vitalchip
Co-authored-by: Rising Leaf <[email protected]>
Co-authored-by: Rising Leaf <[email protected]>
This doesn't have any part in panel.cpp, so removing the change there.
Co-authored-by: Rising Leaf <[email protected]>
And refining the fleet/flagship text to be more in-character.
Flagship and fleet status, personality, target system, hyperspace status...
See plug-in that adds crew, thermal, energy, fuel, and strategic scan with different amounts. Looks rather cool. Plug-in has them very tightly ranged, looks better in practice with larger separation of ranges.
…ndless-sky#8568) The appearance of this message can be deactivated by the "Extra fleet status messages" preference.
RisingLeaf
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, style and etc is not perfect but it works so its fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: This PR implements additional strategic information, accessible by having a scanner with "strategic scan power." This works the same way as Tactical Scan, and also provides the range. By request from Amazinite, this PR now also breaks up all the individual data elements into individually callable attributes, so that an outfit can display just one piece of information, or any collection thereof, and at varying distances.
Feature Details
This feature adds:
Removed stuff
This PR originally included a bunch of useful debug info on what a ship was doing, personalities in use, etc.Removed all the debug stuff, which includes the parent ship identifier, parent system, hyperjump status, and personality info. This needs to be refined and/or hidden behind a "debug only" restriction. With some modifications it could be used as in-character info. Example, instead of displaying parent ship, call it the flagship. For flagships, display number of ships in fleet instead of "parent of X"
credit:
Thanks to @vitalchip for creating the code that makes this possible. They did the original code, I updated it, expanded on it, added the info repositioning logic/data, and did the artwork.
Thanks to Hurleveur for their help working out some change requests and cleaning it up!
Graphics:
Strategic Scan UI elements.zip
UI Screenshots
This shows the info display of a ship that has both tactical and strategic scan power.
An example of a ship with just a tactical scanner:
An example of a ship with just a strategic scanner:
Usage Examples
Someone who prioritizes combat information may want an outfit that just displays range, weapon range, and turning speed.
A faction that has ionizing weapons and enjoys combat might want range, weapon range, turning, and ionization.
A faction that does a lot of boarding might not want anything except the crew count.
The FW, with its preponderance of heat weapons, might be interested in a specialized scanner that just displays range and thermal.
The Navy, fighting against ships wth flamethrowers, might want a scanner that shows range and fuel.
These could also be used to created a cascade of information. For example, in the plug-in I attached to a post farther down, the cascade info scanner will show the player range continuously. At a certain range it'll start showing manouverability info (weapon ranges and turning). Get a bit closer and it'll pick up fuel. Closer yet and it will determine energy, closer still will show thermal, and then when one is practically at the target it will show crew.
Data Usage:
"strategic scan power" 10
"range finder power" 1
(can be any non-zero value, as range finding is infinite.)"crew scan power" 10
"thermal scan power" 10
"energy scan power" 10
"fuel scan power" 10
"weapon scan power" 10
"maneuver scan power" 10
This is used as an attribute on any ship or outfit, in the same exact manner as Tactical Scan.
The display position for all these information values and their associated icon is included in
interfaces.txt
, which means that a player can reposition any of these individually or collectively to anywhere on the screen at their discretion.Testing Done
Played the game and checked to see if the information appeared.
Automated Tests Added
No idea if this needs a test, but it's displaying info, not an action something can do, so I don't think so?
Performance Impact
I don't think there should be any noticeable impact, but I have no idea how to check.
Artwork Checklist
@2x
versions of these art assets: High DPI images for the Strategic Scan UI elements endless-sky-high-dpi#349