Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "ui/tactical" to "ui/tactical/tactical" to match the base game path #435

Conversation

warp-core
Copy link
Contributor

The image at "ui/tactical.png" was moved to "ui/tactical/tactical.png" in endless-sky/endless-sky#8172 but #349 did not make hte corresponding change here. This PR moves the @2x version of that file to match the location of the base resolution version.

Alternatively, that file should not be relocated; it is no longer used by the game and so should either be removed entirely, or left where it is for plugins that might be using it.

Copy link

@TheGiraffe3 TheGiraffe3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR work fine.
I don't think any vanilla plugins would use it; may be better to remove entirely.
There is a mobile buttons plugin that may change this, but I expect that would be updated with thewierdnut's fork.

@warp-core
Copy link
Contributor Author

Closing for now. May reopen depending on the response to endless-sky/endless-sky#8172 (comment).

@warp-core warp-core closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants