feat(proxy): allow to configure the proxy bind address

[jperville]

This PR adds the --bind-address option to the proxy (defaulting to ":8082").

It is backward compatible and can be used to deploy kube-image-keeper in hostNetwork mode as described in #229 .

[jperville]

I take feedback since I'm not a go programmer (yet). I believe that my changes should work because they are consistent with the existing code.

[plaffitt]

Thanks for your contribution! The code looks fine, but I see that you didn't update the helm chart. It would be nice if you could add a way to enable hostNetwork mode in the values as well as customizing the proxy and metrics ports.

[jperville]

Let me see if I can extend the helm chart a bit.

[jperville]

@paullaffitte I added support for hostNetwork in the helm chart.

If the chart is installed with proxy.hostNetwork: true then the proxy daemonset will listen to proxy.hostIP:proxy.hostPort (and the metrics to proxy.hostIP:proxy.metricsPort ).

The default remains to deploy without hostNetwork (deploy using hostIP in the podSpec, which works on most container runtimes but is currently broken with crio runtime).

Since exposing metrics over the hostNetwork is insecure, I force the metrics to listen to localhost instead of all interfaces when in hostNetwork mode. This has the effect of breaking the optional podmonitor feature but I can live with that, I would rather have a working kuik on hostNetwork without podmonitor than a working kuik with insecure metrics.

[plaffitt]

LGTM!

[monkeynator]

🎉 This PR is included in version 1.6.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[monkeynator]

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀