Feat: add support for Provider-defined functions #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Sep 24, 2024
| @@ -0,0 +1,33 @@ | |||
| linters: | |||
There was a problem hiding this comment.
new linter... the older one is longer active...
TomerHeber
commented
Sep 24, 2024
|
|
||
| require ( | ||
| github.com/bmatcuk/doublestar v1.3.4 | ||
| github.com/hashicorp/go-hclog v1.5.0 | ||
| github.com/hashicorp/hcl/v2 v2.16.2 | ||
| github.com/hashicorp/hcl/v2 v2.22.0 |
There was a problem hiding this comment.
upgraded the versions to support provider functions.
TomerHeber
commented
Sep 24, 2024
| - google_beta_resource_skip |
There was a problem hiding this comment.
removed this test from older providers where setting a specific provider version doesn't work...
TomerHeber
commented
Sep 24, 2024
| @@ -3,7 +3,8 @@ | |||
| terraform { | |||
| required_providers { | |||
| google = { | |||
| source = "hashicorp/google" | |||
| source = "hashicorp/google" | |||
| version = "4.84.0" | |||
There was a problem hiding this comment.
need to lock the version... this is because the 'labels' was removed from beta state (now in main version).
therefore, need to lock to a version where this was beta.
TomerHeber
commented
Sep 24, 2024
| } | ||
|
|
||
| output "hashicups_ecr_repository_account_id" { | ||
| value = provider::aws::arn_parse(aws_ecr_repository.hashicups.arn).account_id |
There was a problem hiding this comment.
provider function...
sagydr
reviewed
Sep 25, 2024
sagydr
reviewed
Sep 25, 2024
sagydr
reviewed
Sep 25, 2024
sagydr
reviewed
Sep 25, 2024
sagydr
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #199