Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement forecast = NULL #912

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Implement forecast = NULL #912

wants to merge 11 commits into from

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #911.

Previously, the options for forecast=NULL was not properly handled, so this PR implements that option. It introduces a new internal function for reconciling the case when horizon and forecast are both specified. Tests for the new function as well as missing tests of the forecast argument's functionalities have been added.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam jamesmbaazam requested a review from sbfnk January 10, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for forecast argument suggests can be NULL but errors
1 participant