Tests #1
Open
Tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new test for mMgr.import_files
jkanche
requested changes
Apr 29, 2021
Comment on lines
+34
to
+35
| mMgr = MeasurementManager() | ||
| fms = mMgr.import_records(records, genome="hg19") |
There was a problem hiding this comment.
it might be cumbersome to create a mgr and import records everytime inside each test. Probably should use the same objects from Line 17-18
Comment on lines
+57
to
+63
| def test_mean(): | ||
| mMgr = MeasurementManager() | ||
| fms = mMgr.import_records(records, genome="hg19") | ||
| res = asyncio.run(fms[0].get_data("chr1", 1000000, 1002000, bins=100)) | ||
| df = res[0] | ||
| mean = df['E079-H3K27me3'].mean() | ||
| assert mean == 1.6159404346346855 |
There was a problem hiding this comment.
this should be a computed mean across two measurements, i.e. defining a computed measurements with numpy.mean as the function
|
also tests need to use the handler, they currently don't, as an example, do take a look at the changes and the test script here - 5042ad9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests