Sanitizer support #2
Conversation
Signed-off-by: Igor Egorov <[email protected]>
| @@ -0,0 +1,77 @@ | |||
| # | |||
| # Copyright Soramitsu Co., Ltd. All Rights Reserved. | |||
There was a problem hiding this comment.
where is this coming from? Didn't we have an existing CMakeLists.txt ?
There was a problem hiding this comment.
Upon reflection, I don't think we should be changing this repo for eqlabs/polkadot-light-client#10 at all - we aren't going to use it anyway.
There was a problem hiding this comment.
cpp-libp2p is using it. It needs update if we want to have sanitizer enabled here.
There was a problem hiding this comment.
yes, but cpp-libp2p has more features than we need, and this dependency is for them - IOW I don't think we want to have sanitizer enabled here. @GraDKh?
There was a problem hiding this comment.
Well it worth enabling sanitizer in all the code that is being compiled. But I just came to a thought that we don't need to add some flags in build system here. We can just pass compile and linker flags via cmake in cpp-libp2p
There was a problem hiding this comment.
Ok, so no update in this repo then, just pass all compiler and linker flags from cpp-libp2p.
There was a problem hiding this comment.
BTW if it works, is there any reason it shouldn't be done for soralog as well?
…ass flags to dependencies
No description provided.