Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serde): proper serde and json schema support #29

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

dzmitry-lahoda
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 13, 2025

Pull Request Test Coverage Report for Build 12777915170

Details

  • 0 of 18 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-11.2%) to 50.505%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bounded_vec.rs 0 18 0.0%
Totals Coverage Status
Change from base Build 12112009932: -11.2%
Covered Lines: 50
Relevant Lines: 99

💛 - Coveralls

@dzmitry-lahoda
Copy link
Contributor Author

fails does not seems related to changeset

test src/bounded_vec.rs - bounded_vec::BoundedVec<T,L,U>::opt_empty_vec (line 329) ... FAILED

failures:

---- src/bounded_vec.rs - bounded_vec::BoundedVec<T,L,U>::opt_empty_vec (line 329) stdout ----
error[E0282]: type annotations needed
Error:   --> src/bounded_vec.rs:336:1
   |
10 | assert_eq!(opt_bv_none.to_vec(), vec![]);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type
   |
   = note: this error originates in the macro `assert_eq` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0283]: type annotations needed
Error:   --> src/bounded_vec.rs:336:1
   |
10 | assert_eq!(opt_bv_none.to_vec(), vec![]);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type
   |
   = note: multiple `impl`s satisfying `u8: PartialEq<_>` found in the following crates: `core`, `serde_json`:
           - impl PartialEq for u8;
           - impl PartialEq<serde_json::value::Value> for u8;
   = note: required for `Vec<u8>` to implement `PartialEq<Vec<_>>`
   = note: this error originates in the macro `assert_eq` (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 2 previous errors
Error: aborting due to 2 previous errors
Some errors have detailed explanations: E0282, E0283.
For more information about an error, try `rustc --explain E0282`.
Couldn't compile the test.

failures:
    src/bounded_vec.rs - bounded_vec::BoundedVec<T,L,U>::opt_empty_vec (line 329)

test result: FAILED. 13 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.86s

error: doctest failed, to rerun pass `--doc`
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code [101](https://github.com/ergoplatform/bounded-vec/actions/runs/12754624889/job/35598943787?pr=28#step:6:102)
0s

@SethDusek
Copy link
Collaborator

LGTM, as a final step could you squash your commits? Thanks!

@dzmitry-lahoda
Copy link
Contributor Author

@SethDusek yes I can. Should I reword commit message? Because if not, GitHub 100% has option Squash and Merge

image

@SethDusek SethDusek merged commit ad03a20 into ergoplatform:develop Jan 17, 2025
10 checks passed
@SethDusek
Copy link
Collaborator

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants