Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpeg: fix build with clang 16 #93

Closed

Conversation

stigtsp
Copy link

@stigtsp stigtsp commented Sep 7, 2023

The jpeg configure script fails to detect clang as a functioning C compiler because it uses a test with a main that returns an implicit int, which results in an error with clang 16.

From NixOS/nixpkgs#253730

Cc: @reckenrode

The jpeg `configure` script fails to detect clang as a functioning C
compiler because it uses a test with a `main` that returns an implicit
`int`, which results in an error with clang 16.
@stigtsp stigtsp marked this pull request as ready for review September 9, 2023 12:26
@chrstphrchvz
Copy link
Contributor

I agree that this change is needed. However, other changes are needed for the configure script to work properly and detect e.g. fopen() behavior and whether char is signed. I have opened #94 with those changes as well as the one here.

Note that the CI workflow currently only builds Perl/Tk against system libjpeg (the configure step output contains Using system's -ljpeg rather than Building jpeg/libjpeg.a) and so will not test the changes proposed to this configure script.

@stigtsp
Copy link
Author

stigtsp commented Sep 14, 2023

Ok will close this PR in favor of #94

@stigtsp stigtsp closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants