Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tar_binary_restarts plugin into awicm3 and fesom-2.5. #1075

Merged
merged 16 commits into from
Nov 16, 2023

Conversation

nwieters
Copy link
Contributor

@nwieters nwieters commented Oct 19, 2023

Closes #1072

@nwieters nwieters requested review from JanStreffing and mandresm and removed request for JanStreffing October 19, 2023 14:36
@nwieters nwieters marked this pull request as ready for review October 19, 2023 14:36
@JanStreffing
Copy link
Contributor

Hello @nwieters, thanks for the feature. I would suggest merging into release instead after #1056 is merged.

Base automatically changed from feat/awicm3.2 to release October 19, 2023 17:16
Copy link
Contributor

@mandresm mandresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are broken. My guess is that all versions of fesom2 yamls need the same changes as fesom-2.5.yaml. Otherwise when awicm3 versions <3.2 tries to call the fesom.tidy_recipe it won't be found

configs/components/fesom/fesom-2.5.yaml Outdated Show resolved Hide resolved
@nwieters nwieters requested a review from mandresm October 20, 2023 10:44
@mandresm
Copy link
Contributor

@nwieters, I've added some changes to it to allow for automatically installing missing plugins while using esm_runscripts. This is commonly encountered by people using an old compiled model with an updated version of ESM-Tools that requires a new plugin. This happens because in the past only esm_master was able to automatically install missing plugins, but now both can do so.

Nothing is required from your side, unless you want to give a review and a look at what I did :)

@nwieters
Copy link
Contributor Author

@nwieters, I've added some changes to it to allow for automatically installing missing plugins while using esm_runscripts. This is commonly encountered by people using an old compiled model with an updated version of ESM-Tools that requires a new plugin. This happens because in the past only esm_master was able to automatically install missing plugins, but now both can do so.

Nothing is required from your side, unless you want to give a review and a look at what I did :)

Thank you @mandresm . I had a look at your last commits. From my side it looks good. I would approve. I just realized I can not approve my own PR. :-)

@mandresm
Copy link
Contributor

#approve-changes

@mandresm
Copy link
Contributor

#bump

@mandresm mandresm merged commit c56fbfa into release Nov 16, 2023
@mandresm mandresm deleted the integrate_tar_plugin branch November 16, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging of folders before copying/moving/linking
3 participants