Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint/refactor resubmit #1139

Draft
wants to merge 107 commits into
base: release
Choose a base branch
from
Draft

Sprint/refactor resubmit #1139

wants to merge 107 commits into from

Conversation

nwieters
Copy link
Contributor

No description provided.

nwieters and others added 30 commits September 4, 2023 12:04
mandresm and others added 24 commits February 2, 2024 15:47
@nwieters nwieters self-assigned this Feb 26, 2024
@mandresm
Copy link
Contributor

All tests are broken, even the ones that usually don't break. @nwieters do you know what's going on?

@mandresm
Copy link
Contributor

mandresm commented Feb 28, 2024

After a fast look it seems that some user error is triggered in the pytest. Is it because the pytests are not yet finished?

https://github.com/esm-tools/esm_tools/actions/runs/8047430844/job/21976640630?pr=1139#step:8:419

@nwieters
Copy link
Contributor Author

Yes. Because I changed the cluster of the default phases now all the older tests for the workflow are broken. And for a newer test I need to commit a test config file.
I still need to do some work on this PR.

@mandresm
Copy link
Contributor

Ah okay, sorry, my bad, I understood it was ready to go. Let me know when I can trigger some real tests in Levante.

@mandresm
Copy link
Contributor

@nwieters will look at this and see if can be merge with any of the other branches of the workflow manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants