removing ollie and mistral, as maschines have been removed years ago #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanStreffing
requested review from
pgierz,
joakimkjellsson,
chrisdane,
mandresm and
seb-wahl
mandresm
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Hey @JanStreffing! Thanks a lot for this clean up!!! An excuse from my side: I wanted to do it when I get the tests running for Albedo, so that the Ollie tests can be substituted by Albedo ones. Unfortunatelly, I had no time for that. Anyway, I'll include them with this PR.
In the mean time, you can address the issues I found. The most important one, is to not delete levante.yaml, that would be a bummer hahah
Comment on lines
-20
to
-44
| levante: | ||
| environment_changes: | ||
| add_export_vars: | ||
| - "UDUNITS2_ROOT=/sw/spack-levante/udunits-2.2.28-da6pla/ #/sw/rhel6-x64/util/udunits-2.2.26-gcc64" | ||
| - "FFTW_ROOT=/sw/spack-levante/fftw-3.3.10-lnogal/ #/sw/rhel6-x64/numerics/fftw-3.3.7-openmp-gcc64" | ||
| - "PROJ_ROOT=/sw/spack-levante/proj-5.2.0-w7auht/ #/sw/rhel6-x64/graphics/proj4-4.9.3-gcc48" | ||
| - "PETSC_DIR=/sw/spack-levante/petsc-3.16.2-oorrxp/ #/sw/rhel6-x64/numerics/PETSc-3.12.2-impi2018-intel18/" | ||
| - "HDF5_ROOT=$HDF5ROOT" | ||
| - "LD_LIBRARY_PATH=/sw/spack-levante/gsl-2.7-5ou4yk/lib:$LD_LIBRARY_PATH" | ||
| #- "UDUNITS2_ROOT=/home/a/a270124/model_codes/dependencies/udunits-2.2.28-6havf7" | ||
| #- "FFTW_ROOT=/home/a/a270124/model_codes/dependencies/fftw-3.3.10-bnen2q" | ||
| #- "PROJ_ROOT=/home/a/a270124/model_codes/dependencies/proj-5.2.0-w7auht" | ||
| #- "PETSC_DIR=/home/a/a270124/model_codes/pism/petsc-v3.17.4" | ||
| #- "HDF5_ROOT=$HDF5ROOT" | ||
| #- "LD_LIBRARY_PATH=/home/a/a270124/model_codes/dependencies/gsl-2.7-5ou4yk/lib:$LD_LIBRARY_PATH" | ||
| albedo: | ||
| environment_changes: | ||
| add_export_vars: | ||
| - "UDUNITS2_ROOT=/albedo/soft/sw/spack-sw/udunits/2.2.28-nzwb4bf/" | ||
| - "FFTW_ROOT=/albedo/soft/sw/spack-sw/fftw/3.3.10-pj3kzd2/" | ||
| #- "PROJ4_ROOT=/albedo/home/lackerma/.spack/sw/proj/4.9.2-lcmxjw5" | ||
| - "PROJ_ROOT=/albedo/soft/sw/spack-sw/proj/8.2.1-pq74r7k/" | ||
| - "PETSC_DIR=/albedo/home/lackerma/.spack/sw/petsc/3.17.1-s5b6i2f" | ||
| - "HDF5_ROOT=/albedo/soft/sw/spack-sw/hdf5/1.12.2-xwuyi5j/" | ||
| - "GSL_ROOT=/albedo/soft/sw/spack-sw/gsl/2.7.1-r4x7ty2/" #/albedo/home/lackerma/.spack/sw/gsl/2.7.1-lrzlyrm" |
There was a problem hiding this comment.
This lines will still be needed
| @@ -112,7 +112,6 @@ solidearth_initialize_method: regrid # either dummy, regrid or first_timestep | |||
|
|
|||
| further_reading: | |||
| - pism/pism.domains.yaml | |||
| - pism/pism.compiletime_env_changes.yaml | |||
There was a problem hiding this comment.
This line will still be needed
There was a problem hiding this comment.
I think levante is not yet decomissioned, correct? :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we no longer need these in the live copy. Going back to luck for suggestions of how to do things should have become very rare by now. Time to clean up.