-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/which ale #1200
base: release
Are you sure you want to change the base?
Fix/which ale #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ackerlar, only some questions regarding the ALE scheme configuration.
ale_def: | ||
which_ale: "${ALE_scheme}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something new to FESOM 2.5 or 2.6 or was it always in 2.0 and 2.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the parameters defined below still hold?
# ALE_scheme switch
# -----------------
# Settings for Gent/McWilliams based upon the selected ALE scheme.
choose_ALE_scheme:
linfs:
K_gm_max: "remove_from_namelist"
K_hor: 5000.0
K_gm: 5000.0
zstar:
K_gm_max: 2000.0
K_hor: 3000.0
K_gm: remove_from_namelist
"*":
is: invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! K_hor
should go into namelist.tra/oce_dyn
, K_gm_max
is fine I think, and K_gm
is not needed anymore apparently. But I am unsure about the K_gm_max
setting for linfs
. Is it 3000
then?
Maybe @JanStreffing or @koldunovn can comment on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default GM value differs between FESOM2 core2 standalone (2000) and FESOM2 core2 in AWI-CM3 (3000). The retuning from 3000 to 2000 was found to be beneficial for the standalone model while Nikolay worked on the 2.1. release. I tested both for AWI-CM3.1 and found 3000 produced lower biases.
This holds true till at least FESOM 2.5. I am not aware that the parameter is not used anymore..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JanStreffing ! You are talking about K_gm_max
? Scanning through the code, I could not find a parameter K_gm
. So my question would be, if K_gm
actually is K_gm_max
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, sorry!
k_gm_max = 3000
No description provided.