cleanup.. removed version_attribute

esm-tools · Jan 10, 2025 · 536dd96 · 536dd96
1 parent 6976f3f
commit 536dd96
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 12 deletions.
diff --git a/examples/sample.yaml b/examples/sample.yaml
@@ -77,7 +77,6 @@ pipelines:
       - "pymorize.global_attributes.set_global_attributes"
       - "pymorize.generic.trigger_compute"
       - "pymorize.generic.show_data"
-      - "pymorize.generic.version_attribute"
       - "pymorize.files.save_dataset"
 
 # Settings for using dask-distributed

diff --git a/src/pymorize/generic.py b/src/pymorize/generic.py
@@ -252,9 +252,3 @@ def trigger_compute(data, rule_spec, *args, **kwargs):
         return data.compute()
     # Data doesn't have a compute method, do nothing
     return data
-
-
-def version_attribute(data, rule_spec, *args, **kwargs):
-    if data.attrs.get("version"):
-        data.attrs["version"] = str(data.attrs.get("version"))
-    return data
diff --git a/src/pymorize/pipeline.py b/src/pymorize/pipeline.py
@@ -220,7 +220,6 @@ class DefaultPipeline(FrozenPipeline):
         "pymorize.caching.manual_checkpoint",
         "pymorize.global_attributes.set_global_attributes",
         "pymorize.generic.trigger_compute",
-        "pymorize.generic.version_attribute",
         "pymorize.generic.show_data",
         "pymorize.files.save_dataset",
     )
@@ -251,7 +250,6 @@ class TestingPipeline(FrozenPipeline):
     STEPS = (
         "pymorize.generic.dummy_load_data",
         "pymorize.generic.dummy_logic_step",
-        "pymorize.generic.version_attribute",
         "pymorize.generic.dummy_save_data",
     )
 

diff --git a/tests/configs/test_config_cmip6.yaml b/tests/configs/test_config_cmip6.yaml
@@ -20,7 +20,6 @@ pipelines:
     steps:
       - "pymorize.generic.dummy_load_data"
       - "pymorize.units.handle_unit_conversion"
-      - "pymorize.generic.version_attribute"
       - "pymorize.generic.dummy_save_data"
   - name: "sleeper_pipeline"
     steps:

diff --git a/tests/configs/test_config_cmip7.yaml b/tests/configs/test_config_cmip7.yaml
@@ -20,7 +20,6 @@ pipelines:
     steps:
       - "pymorize.generic.dummy_load_data"
       - "pymorize.units.handle_unit_conversion"
-      - "pymorize.generic.version_attribute"
       - "pymorize.generic.dummy_save_data"
   - name: "sleeper_pipeline"
     steps:

diff --git a/tests/unit/test_global_attributes.py b/tests/unit/test_global_attributes.py
@@ -12,7 +12,6 @@
     ("experiment_id", True),
     ("forcing_index", True),
     ("frequency", True),
-    # ("further_info_url", True),  # set on license, not explicitly req.
     ("grid", True),
     ("grid_label", True),
     ("initialization_index", True),