-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FESOM Regridding #52
base: main
Are you sure you want to change the base?
FESOM Regridding #52
Conversation
Updated CoPilot SummaryThis pull request introduces several changes to integrate FESOM (Finite-Element/volumetric Sea-Ice Ocean Model) functionality into the project. The key changes include updates to CI workflows, new dependencies, and the addition of FESOM-specific regridding functionality. Additionally, there are several updates to the testing framework to accommodate the new features. CI Workflow Enhancements:
Dependency Management:
New FESOM Functionality:
Testing Enhancements:
|
Documentation Preview: https://pymorize.readthedocs.io/en/feat-fesom-regridding/pymorize_fesom.html |
#77 should go in first and this one should get rewritten. |
Summary
@chrisdane wanted FESOM regridding to a regular grid. This PR incorporates
pyfesom2
and usesit's internal tools to convert to a regular grid via nearest neighbor interpolation. You should
specify the grid description (probably best to do this in the
inherit
section of the config), and add the pipelineto the steps you want to take. Provides both a step to include in custom pipelines as well as a pre-built pipeline that performs
the regridding step
TODO:
Merge First
Commits:
Copilot Summary
This pull request introduces several significant changes to the codebase, including enhancements to the CI testing workflow, the addition of new submodules and dependencies, and the implementation of new functionalities for FESOM data processing. Below is a summary of the most important changes:
CI Workflow Enhancements:
CI-test.yaml
to include verbose output and coverage options forpytest
and added doctest modules for thesrc
directory.Submodules and Dependencies:
tests/data/test_experiments/piControl_on_PI/mesh/pi
in.gitmodules
.pyfesom2
under thefesom
extra insetup.py
.FESOM Data Processing:
regrid_to_regular
function andFESOMRegridPipeline
class insrc/pymorize/fesom.py
for regridding FESOM data to a regular grid.FrozenPipeline
and its subclasses insrc/pymorize/pipeline.py
to use class-level attributes forNAME
andSTEPS
, and refactored the initialization method accordingly. [1] [2] [3] [4]Test Configuration and Fixtures:
tests/configs/fesom_pi_mesh_run.yaml
for FESOM mesh run tests.tests/conftest.py
and added new fixtures intests/fixtures
to support FESOM data tests. [1] [2] [3] [4] [5]regrid_to_regular
function intests/unit/test_fesom.py
.