Add support for c++ syntax highlighting in lambdas #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoboda1337
changed the title
swoboda1337
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify things only lambdas tagged with !lambda will be parsed as C++, automatically detecting the payload type in the dashboard is not feasible. IMO this is not a big deal and if someone wants the highlighting they will add the tag.
Some people use the dashboard as their editor. It would be really nice to support embedded C++ syntax highlighting. PR is simple with only 1 line changed, less than 50 new lines and the C++ language definition taken from: https://github.com/microsoft/monaco-editor/blob/main/src/basic-languages/cpp/cpp.ts
Includes library upgrade change from #654
Everything has been tested and is working: