Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow a single BLE request at once #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maikeriva
Copy link

While debugging the application with a custom provisioner firmware code, I noticed it may occasionally send a second request via BLE while still waiting for the previous one's response. When that happens, the response listener gets overwritten (or null'ed) and the response will just went by unprocessed.

The fix which worked for me was to set the semaphore token number to 0 and ensure that the listener is accessed only within the semaphore's protection.

- Set semaphore token number to 0 (1 allows for 2 parallel requests apparently)
- Register/unregister response listener within semaphore protection
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants