chore: bump deps, drop python 3.7 and support python 3.12 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -1 +1 @@ | |||
| cryptography==36.0.0 | |||
| cryptography | |||
There was a problem hiding this comment.
Actually, we have deliberately kept this fixated so as to not break behaviour of any internal functionality.
As the cryptography updates are not backward compatible and may contain breaking changes.
But yes, This version is too old now and should be updated to the latest one.
I will check if the latest cryptography version breaks anything here.
| from cryptography.hazmat.primitives import serialization | ||
| from cryptography.hazmat.backends import default_backend | ||
| from esp_secure_cert.esp_secure_cert_helper import ( |
There was a problem hiding this comment.
Just to note here.
Are you planning to use the custflash_format for your project?
We have already marked the custflash_format as a legacy format.
AdityaHPatwardhan
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If installing with ESP-IDF, it is crucial to align ESP-IDF python dependencies at https://github.com/espressif/esp-idf/blob/master/tools/requirements/requirements.core.txt, to avoid downgrading.