tools/rw-heatmaps: allow overriding running parameters #17755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhbnz
reviewed
Apr 9, 2024
This is definitely not approachable. cc @jmhbnz When we propose list of etcd SLOs that we want to measure, we should also propose more sensible set of samples to test. |
|
@serathius, I agree. That's the reason behind parameterizing this script. |
Currently, the running parameters in the `rw-benchmark.sh` script are hardcoded. Running this script end to end takes around 48 hours with 7 CPU cores. To split the load into smaller jobs, allow these variables to be provided at run time. Signed-off-by: Ivan Valdes <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
rw-individual-benchmark
branch
from
adb147b to
7dfcc60
Compare
jmhbnz
approved these changes
Apr 9, 2024
ivanvc
changed the title
serathius
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the running parameters in the
rw-benchmark.shscript are hardcoded. Running this script end to end takes around 48 hours with 7 CPU cores. To split the load into smaller jobs, allow these variables to be provided at run time.Part of #17754.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.