Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.5 changelog to cover two major fixes #18804

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 29, 2024

@ahrtr ahrtr changed the title Update 3.5 changelog to cover to major fixes Update 3.5 changelog to cover two major fixes Oct 29, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (3696b32) to head (8be847b).

Current head 8be847b differs from pull request most recent head 11cc8bb

Please upload reports for the commit 11cc8bb to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18804      +/-   ##
==========================================
+ Coverage   68.73%   68.79%   +0.05%     
==========================================
  Files         420      420              
  Lines       35512    35512              
==========================================
+ Hits        24410    24430      +20     
+ Misses       9675     9652      -23     
- Partials     1427     1430       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3696b32...11cc8bb. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 29, 2024

/test pull-etcd-integration-1-cpu-amd64

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 36d785d into etcd-io:main Oct 30, 2024
33 checks passed
@ahrtr ahrtr deleted the changelog_20241029 branch October 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants