Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable int-conversion rule of perfsprint #18859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 9, 2024

This fixes int-conversion rule from perfsprint

This helps avoid unnecessary memory allocations.
It doesn't include server and tests folder as they have a lot of impacted files

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35 mmorel-35 marked this pull request as draft November 9, 2024 19:27
@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch 2 times, most recently from adae3ec to 1e09dbe Compare November 9, 2024 19:31
@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Nov 9, 2024
@mmorel-35 mmorel-35 marked this pull request as ready for review November 9, 2024 19:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (40b856e) to head (7215f6a).

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/printer.go 0.00% 11 Missing ⚠️
etcdutl/etcdutl/printer.go 0.00% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
pkg/report/timeseries.go 91.42% <100.00%> (ø)
etcdutl/etcdutl/printer.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/printer.go 0.00% <0.00%> (ø)

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18859      +/-   ##
==========================================
- Coverage   68.77%   68.73%   -0.04%     
==========================================
  Files         420      420              
  Lines       35642    35642              
==========================================
- Hits        24513    24499      -14     
- Misses       9703     9712       +9     
- Partials     1426     1431       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b856e...7215f6a. Read the comment docs.

@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

@ivanvc
Copy link
Member

ivanvc commented Nov 9, 2024

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from 5465913 to deafbd9 Compare November 30, 2024 09:56
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from deafbd9 to bebf4ce Compare December 1, 2024 21:39
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from bebf4ce to f2f79d9 Compare December 11, 2024 06:59
@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from f2f79d9 to 0b3d9ef Compare December 12, 2024 06:23
@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from 0b3d9ef to 7215f6a Compare December 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants