Update: Version update in Changelog #19018
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deanurag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @deanurag. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19018 +/- ##
==========================================
- Coverage 68.75% 68.72% -0.03%
==========================================
Files 420 420
Lines 35629 35623 -6
==========================================
- Hits 24497 24483 -14
- Misses 9705 9713 +8
Partials 1427 1427 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
CHANGELOG/CHANGELOG-3.4.md
Outdated
| @@ -19,7 +19,7 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/ | |||
| - Fix [close temp file(s) in case an error happens during defragmentation](https://github.com/etcd-io/etcd/pull/18855) | |||
|
|
|||
| ### Dependencies | |||
| - Compile binaries using [go 1.22.9](https://github.com/etcd-io/etcd/pull/18850). | |||
| - Compile binaries using [go 1.22.10](https://github.com/etcd-io/etcd/pull/19005). | |||
There was a problem hiding this comment.
Please add a dependencies section in v3.4.36 rather than changing v3.4.35, which has already been released.
There was a problem hiding this comment.
I have made the changes. Please review them.
CHANGELOG/CHANGELOG-3.5.md
Outdated
| @@ -22,7 +22,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
| - Fix [close temp file(s) in case an error happens during defragmentation](https://github.com/etcd-io/etcd/pull/18854) | |||
|
|
|||
| ### Dependencies | |||
| - Compile binaries using [go 1.22.9](https://github.com/etcd-io/etcd/pull/18849). | |||
| - Compile binaries using [go 1.22.10](https://github.com/etcd-io/etcd/pull/19004). | |||
There was a problem hiding this comment.
Please add a dependencies section in v3.5.18 rather than changing v3.5.17, which has already been released.
There was a problem hiding this comment.
I have made the changes. Please review them.
|
Please squash the commits and ensure it's signed off. thx |
deanurag
force-pushed
the
update/changelogUpdate
branch
from
2790124 to
38cf9d6
Compare
|
@deanurag please squash the 6 commits into one, refer to https://graphite.dev/guides/how-to-squash-git-commits Also ensure it's signed off, thx |
This commit will bump dependency go.opentelemetry.io/proto/otlp from 1.3.1 to 1.4.0 Signed-off-by: ArkaSaha30 <[email protected]> Signed-off-by: Anurag De <[email protected]>
deanurag
force-pushed
the
update/changelogUpdate
branch
from
38cf9d6 to
14e91bd
Compare
|
@ahrtr I have squashed the 6 commits into one. |
| @@ -78,7 +78,7 @@ require ( | |||
| go.opentelemetry.io/otel/metric v1.32.0 // indirect | |||
| go.opentelemetry.io/otel/sdk v1.32.0 // indirect | |||
| go.opentelemetry.io/otel/trace v1.32.0 // indirect | |||
| go.opentelemetry.io/proto/otlp v1.3.1 // indirect | |||
| go.opentelemetry.io/proto/otlp v1.4.0 // indirect | |||
Signed-off-by: Anurag De <[email protected]>
|
@deanurag Please ensure
Thanks. |
This commit will bump dependency go.opentelemetry.io/proto/otlp from 1.3.1 to 1.4.0 Signed-off-by: ArkaSaha30 <[email protected]> Signed-off-by: Anurag De <[email protected]>
…etcd into update/changelogUpdate
Updated Versions in the changelog file .
#Part of #19000
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.