Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafthttp: Improve warn message in checkClusterCompatibilityFromHeader #19112

Merged
merged 3 commits into from
Jan 10, 2025
+1 −1
Merged

rafthttp: Improve warn message in checkClusterCompatibilityFromHeader #19112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7577a56
Update misleading warn message when versions mismatch
aladesawe Dec 27, 2024
05ff633
Rephrase warn messaging
aladesawe Dec 28, 2024
a1a9149
Fix typo in typo fix
aladesawe Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/etcdserver/api/rafthttp/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@

if err != nil {
lg.Warn(
"failed to check version compatibility",
"failed version compatibility check",

Check warning on line 489 in server/etcdserver/api/rafthttp/http.go

View check run for this annotation

Codecov / codecov/patch

server/etcdserver/api/rafthttp/http.go#L489 

Added line #L489 was not covered by tests
zap.String("local-member-id", localID.String()),
zap.String("local-member-cluster-id", cid.String()),
zap.String("local-member-server-version", localVs),
Expand Down
Loading