Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release_notes.tpl.txt #19122

Closed
wants to merge 1 commit into from
Closed

Conversation

sunfeilong
Copy link
Contributor

Add space between ${ETCD_VER} and Path

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Add space between ${ETCD_VER} and Path
@k8s-ci-robot
Copy link

Hi @sunfeilong. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jan 8, 2025

Hi @sunfeilong, thanks for your pull request. Hi. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:

git commit --amend --signoff # Fix the signed off trailer
git push --force

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, sunfeilong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member

ahrtr commented Jan 9, 2025

@sunfeilong please signoff the commit. Run commands below,

git rebase HEAD~1 --signoff
git push --force-with-lease origin patch-1

@ahrtr
Copy link
Member

ahrtr commented Jan 9, 2025

/ok-to-test

@k8s-ci-robot
Copy link

@sunfeilong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-1-cpu-amd64 c667fa3 link true /test pull-etcd-integration-1-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (fce823a) to head (c667fa3).
Report is 21 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19122      +/-   ##
==========================================
+ Coverage   68.79%   68.91%   +0.12%     
==========================================
  Files         420      420              
  Lines       35640    35640              
==========================================
+ Hits        24518    24561      +43     
+ Misses       9697     9663      -34     
+ Partials     1425     1416       -9     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce823a...c667fa3. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Jan 9, 2025

We want this for the next release, but we haven't had an answer. Would it be okay if I coauthor the commit in a new PR with the original contributor so we can merge it soon?

@ivanvc
Copy link
Member

ivanvc commented Jan 9, 2025

Closing in favor of #19153.

@ivanvc ivanvc closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants