Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #19066 Print warnings when deprecated options are configured in config file #19148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

test: fix TestConfigFileDeprecatedOptions

d83f391
Select commit
Loading
Failed to load commit list.
Open

fix for #19066 Print warnings when deprecated options are configured in config file #19148

test: fix TestConfigFileDeprecatedOptions
d83f391
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 0s

68.84% (+0.07%) compared to d5231c7

View this Pull Request on Codecov

68.84% (+0.07%) compared to d5231c7

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (d5231c7) to head (d83f391).
Report is 24 commits behind head on main.

Current head d83f391 differs from pull request most recent head f8c0bf3

Please upload reports for the commit f8c0bf3 to get more accurate results.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdmain/config.go 71.05% <100.00%> (+3.28%) ⬆️

... and 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19148      +/-   ##
==========================================
+ Coverage   68.77%   68.84%   +0.07%     
==========================================
  Files         420      420              
  Lines       35640    35649       +9     
==========================================
+ Hits        24510    24543      +33     
+ Misses       9704     9684      -20     
+ Partials     1426     1422       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3388e2b...f8c0bf3. Read the comment docs.