Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable early-return and superfluous-else from revive #19152

Merged
merged 1 commit into from
Jan 19, 2025

chore: enable early-return and superfluous-else from revive

10d7cea
Select commit
Loading
Failed to load commit list.
Merged

chore: enable early-return and superfluous-else from revive #19152

chore: enable early-return and superfluous-else from revive
10d7cea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 18, 2025 in 0s

68.74% (-0.02%) compared to ecd7cfc

View this Pull Request on Codecov

68.74% (-0.02%) compared to ecd7cfc

Details

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.74%. Comparing base (ecd7cfc) to head (10d7cea).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/api/v2store/store.go 33.33% 2 Missing and 2 partials ⚠️
etcdctl/ctlv3/command/check.go 0.00% 3 Missing ⚠️
etcdctl/ctlv3/ctl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
pkg/flags/selective_string.go 100.00% <100.00%> (ø)
server/etcdserver/cluster_util.go 66.17% <100.00%> (-0.13%) ⬇️
server/proxy/grpcproxy/watcher.go 91.83% <100.00%> (-0.17%) ⬇️
server/storage/mvcc/watchable_store.go 93.89% <100.00%> (-0.02%) ⬇️
etcdctl/ctlv3/ctl.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/check.go 0.00% <0.00%> (ø)
server/etcdserver/api/v2store/store.go 83.87% <33.33%> (-0.05%) ⬇️

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19152      +/-   ##
==========================================
- Coverage   68.76%   68.74%   -0.02%     
==========================================
  Files         420      420              
  Lines       35650    35641       -9     
==========================================
- Hits        24513    24500      -13     
+ Misses       9714     9706       -8     
- Partials     1423     1435      +12     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd7cfc...10d7cea. Read the comment docs.