Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gates doc for etcd #941

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gangli113
Copy link

@gangli113 gangli113 commented Jan 7, 2025

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangli113
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gangli113 gangli113 marked this pull request as draft January 7, 2025 00:41
@gangli113 gangli113 force-pushed the addFeatureGatesDoc branch 2 times, most recently from 4beeaa5 to c7d5a67 Compare January 7, 2025 19:04
@gangli113
Copy link
Author

/cc @siyuanfoundation

@gangli113 gangli113 marked this pull request as ready for review January 7, 2025 19:10
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
@siyuanfoundation
Copy link
Contributor

/lgtm Thanks @gangli113 !

/cc @serathius @ahrtr

@jmhbnz
Copy link
Member

jmhbnz commented Jan 8, 2025

/ok-to-test

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline review comment. Thanks!

fix markdown lint error

Signed-off-by: Gang Li <[email protected]>
@gangli113
Copy link
Author

/retest

@gangli113 gangli113 requested a review from spzala January 9, 2025 19:47
You can turn these features on or off using the `--feature-gates` command line flag
on etcd.

Etcd lets you enable or disable a set of feature gates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gangli113 thanks for quickly addressing my comments, and sorry not being picky but the etcd project convention is to use smaller case etcd even when start a sentence. So I would suggest to change Etcd to etcd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants