-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature gates doc for etcd #941
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangli113 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gangli113. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4beeaa5
to
c7d5a67
Compare
c7d5a67
to
1002b6b
Compare
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
eeca4bd
to
1bb29ed
Compare
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
368da16
to
9c18cec
Compare
/lgtm Thanks @gangli113 ! /cc @serathius @ahrtr |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline review comment. Thanks!
fix markdown lint error Signed-off-by: Gang Li <[email protected]>
/retest |
You can turn these features on or off using the `--feature-gates` command line flag | ||
on etcd. | ||
|
||
Etcd lets you enable or disable a set of feature gates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gangli113 thanks for quickly addressing my comments, and sorry not being picky but the etcd project convention is to use smaller case etcd even when start a sentence. So I would suggest to change Etcd
to etcd
.
#940
This change copied most content from https://github.com/kubernetes/website/edit/main/content/en/docs/reference/command-line-tools-reference/feature-gates/index.md.