Skip to content

Commit

Permalink
AA-518 make aggregator.validateSignatures non-view
Browse files Browse the repository at this point in the history
There is no need to restrict validateSignatures to be a view function.
The aggregator is a staked entity, so if it does cause an issue (e.g.
unexpected bundle creation failure), the aggregator will get banned.
  • Loading branch information
drortirosh committed Jan 15, 2025
1 parent b3bae63 commit 37e246d
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions contracts/interfaces/IAggregator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ import "./PackedUserOperation.sol";
*/
interface IAggregator {
/**
* Validate aggregated signature.
* Revert if the aggregated signature does not match the given list of operations.
* @param userOps - Array of UserOperations to validate the signature for.
* Validate an aggregated signature.
* Reverts if the aggregated signature does not match the given list of operations.
* @param userOps - An array of UserOperations to validate the signature for.
* @param signature - The aggregated signature.
*/
function validateSignatures(
PackedUserOperation[] calldata userOps,
bytes calldata signature
) external view;
) external;

/**
* Validate signature of a single userOp.
* Validate the signature of a single userOp.
* This method should be called by bundler after EntryPointSimulation.simulateValidation() returns
* the aggregator this account uses.
* First it validates the signature over the userOp. Then it returns data to be used when creating the handleOps.
Expand All @@ -34,8 +34,8 @@ interface IAggregator {
/**
* Aggregate multiple signatures into a single value.
* This method is called off-chain to calculate the signature to pass with handleOps()
* bundler MAY use optimized custom code perform this aggregation.
* @param userOps - Array of UserOperations to collect the signatures from.
* bundler MAY use optimized custom code to perform this aggregation.
* @param userOps - An array of UserOperations to collect the signatures from.
* @return aggregatedSignature - The aggregated signature.
*/
function aggregateSignatures(
Expand Down

0 comments on commit 37e246d

Please sign in to comment.