Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPS Initialize #406

Merged
merged 36 commits into from
Dec 16, 2024
Merged

FPS Initialize #406

merged 36 commits into from
Dec 16, 2024

Conversation

ElliotFriedman
Copy link
Contributor

Description

Vendor AddressRegistry contract
Add foundry tests
Add circleci task to run foundry tests
Create constants file
Start FPS documentation

Tests

Tests have been added for the AddressRegistry contract, with all functions being called and only 2 branches in the constructor that have not been tested.

Metadata

Part 1 of this issue: #397

ElliotFriedman and others added 29 commits December 10, 2024 13:05
@ElliotFriedman
ignore lcov file
f9c1762 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
add: rpc endpoints
03ba7f4 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
fps init: address registry and mock addresses
5ab001f 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
init: mock data for address registry tests
6e5172d 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
add: mainnet registry tests
f575657 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
add: local registry tests
d05dd96 
Signed-off-by: Elliot <[email protected]>
@prateek105
add logic to read superchain addresses
e121753
@prateek105
add tests
2dd3a0e
@ElliotFriedman
Merge pull request #3 from solidity-labs-io/feat/fps-read-superchain
3bd4cec 
feat: read superchain addresses
@prateek105
use l2 instance chain id in registry mapping
1f6d997
@prateek105
update interface
7d720b4
@prateek105
move chainList toml to addresses folder
5923b1c
@prateek105
update addresses toml file names as per chain ids in chainList toml
7e80b5f
@prateek105
fix tests
c7e313a
@prateek105
forge fmt
1256800
@prateek105
update superchain addresses type check
b56bd5b
@prateek105
update variable name
3a52ad9
@ElliotFriedman
add: forge test to circleci
0193c15 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
Merge pull request #5 from solidity-labs-io/fix/update-registry-l2cha…
490bf31 
…inid

update registry mapping to use l2 instance chain id
@ElliotFriedman
Merge pull request #6 from solidity-labs-io/add/ci-test
58507b3 
add: forge test to circleci
@ElliotFriedman
add additional assertions for supported chain ids, add more construct…
2dedb8f 
…ion failure tests

Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
add supported chainids and corresponding checks on getters, natspec, …
47b4dde 
…improve error messages

Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
natspec
221ec63 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
initial constants
b70d2b4 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
mock with duplicate chain configurations
09b2fb0 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
Merge pull request #7 from solidity-labs-io/add-supported-chainids
6bb724b 
Add supported chainids
@ElliotFriedman
remove lcov from gitignore
10e1911 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
address registry doco
7ac03a8 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
Merge pull request #8 from solidity-labs-io/add-supported-chainids
03a5fb6 
remove lcov from gitignore
@ElliotFriedman ElliotFriedman requested a review from a team as a code owner December 13, 2024 05:35
@ElliotFriedman ElliotFriedman requested a review from a team as a code owner December 13, 2024 05:35
@mds1 mds1 requested a review from blmalone December 13, 2024 14:06
mds1
mds1 reviewed Dec 13, 2024
View reviewed changes
src/fps/utils/Constants.sol Outdated Show resolved Hide resolved
blmalone
blmalone previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looks good to me. I've left one comment but that's non-blocking and for my own understanding.

src/fps/AddressRegistry.sol Outdated Show resolved Hide resolved
@mds1 mds1 mentioned this pull request Dec 14, 2024
Merged
blmalone
blmalone previously approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blmalone
Copy link
Contributor

/ci authorize 6528291

@blmalone blmalone enabled auto-merge December 15, 2024 16:46
@ElliotFriedman
fmt
a501b54 
Signed-off-by: Elliot <[email protected]>
auto-merge was automatically disabled December 16, 2024 16:59

Head branch was pushed to by a user without write access

@blmalone blmalone self-requested a review December 16, 2024 17:49
@blmalone
Copy link
Contributor

/ci authorize a501b54

@blmalone blmalone added this pull request to the merge queue Dec 16, 2024
Merged via the queue into ethereum-optimism:main with commit 1d3cbec Dec 16, 2024
14 checks passed
@blmalone blmalone mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blmalone blmalone blmalone approved these changes

@clabby clabby Awaiting requested review from clabby clabby is a code owner automatically assigned from ethereum-optimism/contract-reviewers

@mds1 mds1 Awaiting requested review from mds1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElliotFriedman @blmalone @mds1 @prateek105