Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create story for DocLink component #14595

Closed
4 tasks
Tracked by #13043
corwintines opened this issue Jan 2, 2025 · 3 comments · Fixed by #14630
Closed
4 tasks
Tracked by #13043

Create story for DocLink component #14595

corwintines opened this issue Jan 2, 2025 · 3 comments · Fixed by #14630
Assignees
@alexandriaroberts

Comments

@corwintines
Copy link
Member

corwintines commented Jan 2, 2025 •
edited
Loading

Create story tests for DocLink component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Move /src/components/DocLink.tsx to /src/components/DocLink/index.tsx
  • Fix any filepath changes to imports for the DocLink component
  • Create story file /src/components/DocLink/DocLink.stories.tsx
  • Writes story testing render of DocLink component in context of use

Context

Used on the history page
@corwintines corwintines mentioned this issue Jan 2, 2025
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jan 2, 2025
@corwintines corwintines changed the title DocLink Create story for DocLink component Jan 2, 2025
@yash251
Copy link
Contributor

yash251 commented Jan 3, 2025

can you assign me?

@alexandriaroberts
Copy link
Contributor

Hi @corwintines , I would like to take it. Thank you.

@corwintines
Copy link
Member Author

Assigned @alexandriaroberts!

@yash251 I can create another one for you, but alexandria reached out to me for this one. Ill ping you in a new issue!

alexandriaroberts added a commit to alexandriaroberts/ethereum-org-website that referenced this issue Jan 9, 2025
@alexandriaroberts
Added story for DocLink component [resolves ethereum#14595]
6d75cc7
@alexandriaroberts alexandriaroberts mentioned this issue Jan 9, 2025
Merged
4 tasks
@isabelladebrito isabelladebrito removed the needs triage 📥 This issue needs triaged before being worked on label Jan 9, 2025
corwintines added a commit that referenced this issue Jan 21, 2025
@corwintines
Merge pull request #14630 from alexandriaroberts/add_story_tests_for_…
e2fa609 
…DocLink_component

Added story for DocLink component [resolves #14595]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandriaroberts alexandriaroberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added story for DocLink component [resolves #14595] alexandriaroberts/ethereum-org-website
4 participants
@corwintines @alexandriaroberts @yash251 @isabelladebrito