Added story for DocLink component [resolves #14595] #14630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandriaroberts
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks @alexandriaroberts! Left one note about placement of the story, otherwise this looks great to me!
Co-authored-by: Paul Wackerow <[email protected]>
corwintines
approved these changes
Jan 21, 2025
|
@all-contributors can you add @alexandriaroberts for code |
|
I've put up a pull request to add @alexandriaroberts! 🎉 |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2025 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created story tests for the DocLink component
Description
Move /src/components/DocLink.tsx to /src/components/DocLink/index.tsx
Fix any filepath changes to imports for the DocLink component
Create story file /src/components/DocLink/DocLink.stories.tsx
Writes story testing render of DocLink component in context of use
Related Issue
Closes #14595