feat: Migrate SideNav to Shadcn/Tailwind #14508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashiskumar-1999
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
❌ Deploy Preview for ethereumorg failed.
|
ashiskumar-1999
changed the title
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
pettinarip
requested changes
Dec 30, 2024
src/components/SideNav.tsx
Outdated
| @@ -2,7 +2,7 @@ import { useEffect, useState } from "react" | |||
| import { motion } from "framer-motion" | |||
| import { useTranslation } from "next-i18next" | |||
| import { MdChevronRight } from "react-icons/md" | |||
| import { Box, HStack, Icon } from "@chakra-ui/react" | |||
| import { Box } from "@chakra-ui/react" | |||
There was a problem hiding this comment.
This needs to be migrated too.
…to-Shadcn/Tailwind
…to-Shadcn/Tailwind
…to-Shadcn/Tailwind
pettinarip
reviewed
Jan 6, 2025
src/components/SideNav.tsx
Outdated
| ps={8} | ||
| _hover={{ bgColor: "ednBackground" }} | ||
| > | ||
| <HStack className="w-full justify-between py-2 pe-4 ps-8 hover:bg-[ednBackground]"> |
There was a problem hiding this comment.
Suggested change
| <HStack className="w-full justify-between py-2 pe-4 ps-8 hover:bg-[ednBackground]"> | |
| <HStack className="w-full justify-between py-2 pe-4 ps-8 hover:bg-background-highlight"> |
src/components/SideNav.tsx
Outdated
| > | ||
| <Icon as={MdChevronRight} boxSize={6} color="secondary" /> | ||
| </Box> | ||
| <MdChevronRight className="h-6 w-6" color="secondary" /> |
There was a problem hiding this comment.
Suggested change
| <MdChevronRight className="h-6 w-6" color="secondary" /> | |
| <MdChevronRight className="h-6 w-6" color="secondary" /> |
Suggested change
| <MdChevronRight className="h-6 w-6" color="secondary" /> | |
| <MdChevronRight className="h-6 w-6 text-body-medium" /> |
src/components/SideNav.tsx
Outdated
| borderInlineEndColor="border" | ||
| display={{ base: "none", lg: "block" }} | ||
| <nav | ||
| className="sticky top-[4.75rem] pt-8 pb-16 h-[calc(100vh - 80px)] w-[calc((100% - 1448px) / 2 + 256px)] min-w-256 overflow-y-auto transition-transform duration-200 ease bg-[background.base] shadow-[1px_0px_0px_rgba(0,0,0,0.1)] border-e border-e-border lg:block" |
There was a problem hiding this comment.
Suggested change
| className="sticky top-[4.75rem] pt-8 pb-16 h-[calc(100vh - 80px)] w-[calc((100% - 1448px) / 2 + 256px)] min-w-256 overflow-y-auto transition-transform duration-200 ease bg-[background.base] shadow-[1px_0px_0px_rgba(0,0,0,0.1)] border-e border-e-border lg:block" | |
| className="sticky top-[4.75rem] pt-8 pb-16 h-[calc(100vh - 80px)] w-[calc((100% - 1448px) / 2 + 256px)] min-w-256 overflow-y-auto transition-transform duration-200 ease bg-background shadow-[1px_0px_0px_rgba(0,0,0,0.1)] border-e border-e-border lg:block" |
…to-Shadcn/Tailwind
This reverts commit 209711e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated the necessary chakra-UI imports to Shadcn/TailwindCSS.
#13946