Allow masking without primary keys #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5575/merge
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
galvana
added
the
run unsafe ci checks
13 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## split-query-config-files #5575 +/- ##
=============================================================
+ Coverage 71.31% 87.14% +15.82%
=============================================================
Files 388 388
Lines 23988 24000 +12
Branches 2594 2593 -1
=============================================================
+ Hits 17107 20914 +3807
+ Misses 6326 2525 -3801
- Partials 555 561 +6 ☔ View full report in Codecov by Sentry. |
galvana
commented
Jan 7, 2025
Comment on lines
+609
to
+614
| if ( | ||
| self.connector.requires_primary_keys | ||
| and not self.execution_node.collection.contains_field( | ||
| lambda f: f.primary_key | ||
| ) | ||
| ): |
There was a problem hiding this comment.
Key change - This is where I added the additional check for requires_primary_keys
Comment on lines
+103
to
+110
| @property | ||
| def reference_field_paths(self) -> Dict[FieldPath, Field]: | ||
| """Mapping of FieldPaths to Fields that have incoming identity or dataset references""" | ||
| return { | ||
| field_path: field | ||
| for field_path, field in self.field_map().items() | ||
| if field_path in {edge.f2.field_path for edge in self.node.incoming_edges} | ||
| } |
There was a problem hiding this comment.
Very important change - this is what allows us to use the dataset references instead of the primary key fields for the where clauses
eastandwestwind
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LA-95
Description Of Changes
Removed the need to include primary keys for erasure requests for BigQuery and Postgres. Before this change, all connectors required collections to have one field that contained
primary_key: Truefor that collection to be masked. In order to make this an incremental change, I added arequires_primary_keysproperty toBaseConnectorwhich I defaulted toTrue. Every connector can either override this, or keep the default behavior.Code Changes
requires_primary_keysto Falserequires_primary_keysto Falserequires_primary_keysto True and included a comment about ScyllaDB requiring the where clause for an update to be a primary keySteps to Confirm
primary_keyannotations fromsrc/fides/data/sample_project/sample_resources/postgres_example_test_dataset.ymlnox -s "fides_env(test)"[email protected]. Verify both are still possible without primary keys.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works