HJ-352 - Fixes some fields that are not present on the CSV and they shouldn't be present on the web datamap report #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…houldn't be present on the web datamap report
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5645/merge
|
| Run status |
|
| Run duration | 01m 01s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/smoke_test.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Smoke test > can access Mongo and Postgres connectors from the Admin UI |
Screenshots
Video
|
|
| @@ -24,7 +24,7 @@ | |||
| "legal_address", | |||
| "cookie_refresh", | |||
| "data_security_practices", | |||
| "DATA_SHARED_WITH_THIRD_PARTIES", | |||
| "data_shared_with_third_parties", | |||
There was a problem hiding this comment.
wrong uppercase fixed
| @@ -241,6 +241,9 @@ export const getDatamapReportColumns = ({ | |||
| columnHelper.accessor((row) => row.data_shared_with_third_parties, { | |||
| id: COLUMN_IDS.DATA_SHARED_WITH_THIRD_PARTIES, | |||
| }), | |||
| columnHelper.accessor((row) => row.processes_special_category_data, { | |||
There was a problem hiding this comment.
Now we include this field on the web report
| @@ -364,9 +367,6 @@ export const getDatamapReportColumns = ({ | |||
| columnHelper.accessor((row) => row.legitimate_interest_disclosure_url, { | |||
| id: COLUMN_IDS.LEGITIMATE_INTEREST_DISCLOSURE_URL, | |||
| }), | |||
| columnHelper.accessor((row) => row.link_to_processor_contract, { | |||
There was a problem hiding this comment.
this field was deprecated, now it's gone
| }, | ||
| }), | ||
| columnHelper.accessor((row) => row.third_country_safeguards, { | ||
| id: COLUMN_IDS.THIRD_COUNTRY_SAFEGUARDS, |
There was a problem hiding this comment.
this field was deprecated, now it's gone
| @@ -414,24 +414,6 @@ export const getDatamapReportColumns = ({ | |||
| columnHelper.accessor((row) => row.special_category_legal_basis, { | |||
| id: COLUMN_IDS.SPECIAL_CATEGORY_LEGAL_BASIS, | |||
| }), | |||
| columnHelper.accessor((row) => row.system_dependencies, { | |||
| id: COLUMN_IDS.SYSTEM_DEPENDENCIES, | |||
There was a problem hiding this comment.
this field was deprecated, now it's gone
| @@ -27,7 +27,7 @@ export enum COLUMN_IDS { | |||
| LEGAL_ADDRESS = "legal_address", | |||
| COOKIE_REFRESH = "cookie_refresh", | |||
| DATA_SECURITY_PRACTICES = "data_security_practices", | |||
| DATA_SHARED_WITH_THIRD_PARTIES = "DATA_SHARED_WITH_THIRD_PARTIES", | |||
There was a problem hiding this comment.
wrong letter casing for the field
| @@ -115,4 +110,6 @@ export const DEFAULT_COLUMN_NAMES: Record<COLUMN_IDS, string> = { | |||
| [COLUMN_IDS.USES_COOKIES]: "Uses cookies", | |||
| [COLUMN_IDS.USES_NON_COOKIE_ACCESS]: "Uses non-cookie access", | |||
| [COLUMN_IDS.USES_PROFILING]: "Uses profiling", | |||
| [COLUMN_IDS.PROCESSES_SPECIAL_CATEGORY_DATA]: | |||
There was a problem hiding this comment.
new field on web
| @@ -104,8 +101,6 @@ export const DEFAULT_COLUMN_NAMES: Record<COLUMN_IDS, string> = { | |||
| [COLUMN_IDS.RETENTION_PERIOD]: "Retention period", | |||
| [COLUMN_IDS.SHARED_CATEGORIES]: "Shared categories", | |||
| [COLUMN_IDS.SPECIAL_CATEGORY_LEGAL_BASIS]: "Special category legal basis", | |||
| [COLUMN_IDS.SYSTEM_DEPENDENCIES]: "System dependencies", | |||
| [COLUMN_IDS.THIRD_COUNTRY_SAFEGUARDS]: "Third country safeguards", | |||
There was a problem hiding this comment.
this field was deprecated, now it's gone
| @@ -104,8 +101,6 @@ export const DEFAULT_COLUMN_NAMES: Record<COLUMN_IDS, string> = { | |||
| [COLUMN_IDS.RETENTION_PERIOD]: "Retention period", | |||
| [COLUMN_IDS.SHARED_CATEGORIES]: "Shared categories", | |||
| [COLUMN_IDS.SPECIAL_CATEGORY_LEGAL_BASIS]: "Special category legal basis", | |||
| [COLUMN_IDS.SYSTEM_DEPENDENCIES]: "System dependencies", | |||
There was a problem hiding this comment.
this field was deprecated, now it's gone
| [COLUMN_IDS.JOINT_CONTROLLER_INFO]: "Joint controller info", | ||
| [COLUMN_IDS.LEGAL_BASIS_FOR_PROFILING]: "Legal basis for profiling", | ||
| [COLUMN_IDS.LEGAL_BASIS_FOR_TRANSFERS]: "Legal basis for transfers", | ||
| [COLUMN_IDS.LEGITIMATE_INTEREST_DISCLOSURE_URL]: | ||
| "Legitimate interest disclosure URL", | ||
| [COLUMN_IDS.LINK_TO_PROCESSOR_CONTRACT]: "Link to processor contract", |
There was a problem hiding this comment.
this field was deprecated, now it's gone
gilluminate
approved these changes
Jan 9, 2025
fides
|
||||||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 01m 01s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
1
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/smoke_test.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Smoke test > can access Mongo and Postgres connectors from the Admin UI |
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HJ-352
Description Of Changes
Fixes some fields that are not present on the CSV and they shouldn't be present on the web datamap report
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works